I have added support for using custom HTTP clients in a backward-compatible way. The way this works, is that I made an HTTP Client interface, with two implementations: CurlClient and StreamClient. The code for these implementations was refactored out of the original HTTPMessage::send() method.

You can use the new HTTPMessage::setHttpClient() method to inject any HTTP client that conforms to the aforementioned interface. If none is injected, the HTTPMessage chooses one for you, using a similar strategy found in the original class.

I also improved the code for the fopen-based client, since it was not handling the response data properly like cURL code was doing.

Additional Changes

• Project-level configuration files typically found in open source PHP projects, including:
  • .editorconfig with a basic PSR-compliant configuration
  • .gitignore for excluding composer files that should not be committed
  • phpunit.xml.dist for configuring PHPUnit. To override this file in your own development environment, you can copy it to phpunit.xml and make changes.
• A PHPUnit-based test suite that covers the HTTPMessage, CurlClient, and StreamClient classes.
  • Testing code that uses functions with side-effects like curl_exec and fopen is not easy. I opted to use PHP's built-in server (with an object-oriented wrapper) to respond with canned results that I can test against. This setup worked fine in my Mac-based PHP environment, but I'm not sure how well it works in non-bash environments. Can be changed in the future, but wanted to be thorough on the tests.

Test Output

> phpunit --coverage-text
PHPUnit 5.6.2 by Sebastian Bergmann and contributors.

.............                                                     13 / 13 (100%)

Time: 1.19 seconds, Memory: 6.00MB

OK (13 tests, 28 assertions)


Code Coverage Report:      
  2016-11-11 03:03:21      
                           
 Summary:                  
  Classes:  9.30% (4/43)   
  Methods:  1.89% (6/318)  
  Lines:    1.37% (63/4596)

\IMSGlobal\LTI::HTTPMessage
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 11/ 11)
\IMSGlobal\LTI\HTTP::CurlClient
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% ( 35/ 35)
\IMSGlobal\LTI\HTTP::StreamClient
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% ( 17/ 17)